Adding logo assets - #235
Merged
jstone-lucasfilm merged 8 commits intoSep 16, 2024
Merged
Conversation
portsmouth
changed the title
Contributor
Author
|
An admin is needed to change the project icon to the OpenPBR glyph. |
Signed-off-by: Jamie Portsmouth <jamports@mac.com>
Contributor
Author
|
Some alternative layouts for the title and logo placement. I like the second version the most, with the logo+text used for the title, and the subtitle giving the detailed "OpenPBR Surface specification" and the version/date. **OpenPBR Surface**
<center>*Specification v1.1, 2024-06-28*.</center>
<center>
<a href="https://github.com/AcademySoftwareFoundation/OpenPBR" title="Redirect to GitHub page"><img src="images/logo/openpbr-logo.svg" alt="homepage" height="48" style="vertical-align: middle; position: relative; bottom: 0px"/></a>
<a href="https://www.aswf.io/" title="Redirect to ASWF page"><img src="images/aswf-logo-black.svg" alt="homepage" height="36" style="vertical-align: middle; position: relative; bottom: 0px"/></a>
</center>
<center>
<a href="https://github.com/AcademySoftwareFoundation/OpenPBR"><img src="images/logo/openpbr-logo-glyph.svg" alt="homepage" height="80" style="vertical-align: middle; position: relative; bottom: 0px"/></a>
<a href="https://github.com/AcademySoftwareFoundation/OpenPBR"><img src="images/logo/openpbr-logo-text.svg" alt="homepage" height="100" style="vertical-align: middle; position: relative; bottom: 0px"/></a>
</center>
<style>bigger { font-style: italic; font-weight: normal; font-size: 115%;}</style>
<center><bigger><i>OpenPBR Surface specification v1.1, 2024-06-28</i></bigger></center>
|
Contributor
Author
Contributor
Author
|
In 54474ff updated the spec to use the logo (glyph next to text form) for the title, with the subtitle giving the full "OpenPBR Surface" (+version/date) wording. |
Contributor
Author
|
Added proposed 128x128 favicon in 95cc4ba
|
virtualzavie
approved these changes
Sep 12, 2024
virtualzavie
left a comment
virtualzavie
left a comment
Contributor
There was a problem hiding this comment.
Thank you! I'm really pleased to see how good this looks both on dark and light backgrounds.
Comment on lines
-5
to
+10
| **OpenPBR Surface** | ||
| <center> | ||
| <a href="https://github.com/AcademySoftwareFoundation/OpenPBR"><img src="images/logo/openpbr-logo-glyph.svg" alt="homepage" height="80" style="vertical-align: middle; position: relative; bottom: 0px"/></a> | ||
| | ||
| <a href="https://github.com/AcademySoftwareFoundation/OpenPBR"><img src="images/logo/openpbr-logo-text.svg" alt="homepage" height="100" style="vertical-align: middle; position: relative; bottom: 0px"/></a> | ||
| </center> |
Contributor
There was a problem hiding this comment.
As a minor remark, I think we lost a bit of semantic here by replacing the header text with an image, but I don't know what would be the correct way of doing it within Markdeep.
Contributor
Author
There was a problem hiding this comment.
Yeah, though I'm not sure it matters that the Markdeep title is missing. I would have preferred to have the subtitle be the Markdeep title, and put the logo above, but Markdeep doesn't seem to allow that.
AdrienHerubel
self-requested a review
September 12, 2024 17:18
AdrienHerubel
approved these changes
Sep 12, 2024
AdrienHerubel
left a comment
AdrienHerubel
left a comment
Contributor
There was a problem hiding this comment.
New logo and updated specification LGTM
|
looking good! |
jstone-lucasfilm
approved these changes
Sep 16, 2024
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
These changes look good to me, thanks @portsmouth!
portsmouth
added a commit
to portsmouth/OpenPBR
that referenced
this pull request
Jun 10, 2025
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
portsmouth
added a commit
to portsmouth/OpenPBR
that referenced
this pull request
Jun 10, 2025
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
portsmouth
added a commit
to portsmouth/OpenPBR
that referenced
this pull request
Jun 10, 2025
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
AdrienHerubel
pushed a commit
to AdrienHerubel/OpenPBR
that referenced
this pull request
Apr 17, 2026
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
Merged
jstone-lucasfilm
pushed a commit
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding here the finalized logo. This is almost identical to the one posted on Slack, except:
extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke
SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
Assets
White paper
README