Skip to content

feat(webp): Respect the oiio:UnassociatedAlpha attribute#4770

Merged
lgritz merged 2 commits into
AcademySoftwareFoundation:mainfrom
jessey-git:webp-unassoc
May 18, 2025
Merged

feat(webp): Respect the oiio:UnassociatedAlpha attribute#4770
lgritz merged 2 commits into
AcademySoftwareFoundation:mainfrom
jessey-git:webp-unassoc

Conversation

@jessey-git
Copy link
Copy Markdown
Contributor

@jessey-git jessey-git commented May 17, 2025

Description

Similar to other formats like PNG, make WEBP respect the oiio:UnassociatedAlpha attribute value in case client applications are already handling the alpha association themselves.

Tests

Unsure how best to test this?

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

jessey-git added 2 commits May 17, 2025 14:01
@jessey-git
feat(webp): Respect the oiio:UnassociatedAlpha attribute
4b8c4c9 
Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
@jessey-git
Add docs
fe373a0 
Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
lgritz
lgritz approved these changes May 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit 01392e6 into AcademySoftwareFoundation:main May 18, 2025
30 checks passed
scott-wilson pushed a commit to scott-wilson/OpenImageIO that referenced this pull request May 18, 2025
@jessey-git @scott-wilson
feat(webp): Respect the oiio:UnassociatedAlpha attribute (AcademySo…
2a4b2c5 
…ftwareFoundation#4770)

Similar to other formats like PNG, make WEBP respect the
`oiio:UnassociatedAlpha` attribute value in case client applications are
already handling the alpha association themselves.

---------

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
Signed-off-by: Scott Wilson <scott@propersquid.com>
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request May 19, 2025
@jessey-git @lgritz
feat(webp): Respect the oiio:UnassociatedAlpha attribute (AcademySo…
2aea0cf 
…ftwareFoundation#4770)

Similar to other formats like PNG, make WEBP respect the
`oiio:UnassociatedAlpha` attribute value in case client applications are
already handling the alpha association themselves.

---------

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
@jessey-git jessey-git deleted the webp-unassoc branch June 23, 2025 00:24
zachlewis pushed a commit to zachlewis/OpenImageIO that referenced this pull request Aug 1, 2025
@jessey-git @zachlewis
feat(webp): Respect the oiio:UnassociatedAlpha attribute (AcademySo…
e595d3d 
…ftwareFoundation#4770)

Similar to other formats like PNG, make WEBP respect the
`oiio:UnassociatedAlpha` attribute value in case client applications are
already handling the alpha association themselves.

---------

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
@BrewTestBot BrewTestBot mentioned this pull request Oct 2, 2025
Merged
brechtvl added a commit to brechtvl/oiio that referenced this pull request Jan 29, 2026
@brechtvl
fix(webp): Missing oiio:UnassociatedAlpha on input
84a2ab8 
Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
@brechtvl brechtvl mentioned this pull request Jan 29, 2026
Merged
6 tasks
lgritz pushed a commit that referenced this pull request Jan 29, 2026
@brechtvl
fix(webp): Missing oiio:UnassociatedAlpha on input (#5020)
fb8cde9 
Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in #4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Jan 30, 2026
@brechtvl @lgritz
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
debfde2 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Feb 24, 2026
@brechtvl @ssh4net
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
70f643d 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 1, 2026
@brechtvl @ssh4net
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
aa36e7c 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad <shaamaan@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
@brechtvl @ssh4net
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
f84f543 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
@brechtvl @ssh4net
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
6a2da6c 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
@brechtvl @ssh4net
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
9e85353 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
@brechtvl @ssh4net
fix(webp): Missing oiio:UnassociatedAlpha on input (AcademySoftwareFo…
55807a4 
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgritz lgritz lgritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessey-git @lgritz