api: first draft for removing nativespec from ImageBuf #4482
+138
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Basile Fraboni <basile.fraboni@gmail.com>
Signed-off-by: Basile Fraboni <basile.fraboni@gmail.com>
Signed-off-by: Basile Fraboni <basile.fraboni@gmail.com>
Signed-off-by: Basile Fraboni <basile.fraboni@gmail.com>
lgritz
reviewed
Oct 10, 2024
| const ImageSpec& nativespec() const; | ||
| TypeDesc file_format() const; | ||
| /// Same as the above for channel specific formats. | ||
| std::vector<TypeDesc> file_channelformats() const; |
There was a problem hiding this comment.
Not sure how much it matters, but do you think returning a vector is good here? As opposed to returning a const vector& or a cspan<TypeDesc>? (But those are only options it's stored somewhere in the IB and we can make a stable reference to it.
lgritz
reviewed
Oct 10, 2024
| @@ -361,7 +361,9 @@ declare_imagebuf(py::module& m) | |||
| "height"_a = 0, "depth"_a = 0) | |||
| .def("spec", &ImageBuf::spec, | |||
| py::return_value_policy::reference_internal) | |||
| .def("nativespec", &ImageBuf::nativespec, | |||
| .def("file_format", &ImageBuf::file_format, | |||
There was a problem hiding this comment.
I think here, like with C++, for back compatibility we'll want to preserve a nativespec() call, even if it does something different than before.
|
I think this is going in the right direction. Looks like failed tests? And you need a DCO? |
|
Just a remind that there are some pending items to finish this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second half of API changes to remove
nativespecfromImageCacheandImageBuffor issue: #4436nativespec()from the ImageBuf API but this creates a bunch of problems I have not answers for inImageBuf::read