Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: More warning elimination for clang18 #4257

Merged
merged 1 commit into from
May 5, 2024

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented May 4, 2024

This is a continuation of PR 4246, had one more spot where we needed to disable warnings for unity builds involving clang18 and deprecated unicode conversion functions.

There's some changes included to ci.yml and install_homebrew_deps.bash that are part of work I did to make it easier for me to force it to use clang-18 for certain tests while working on this.

This is a continuation of PR 4246, had one more spot where we needed
to disable warnings for unity builds involving clang18 and deprecated
unicode conversion functions.

There's some changes included to ci.yml and install_homebrew_deps.bash
that are part of work I did to make it easier for me to force it to
use clang-18 for certain tests while working on this.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented May 4, 2024

@fpsunflower This should fix that OSL Mac CI failure.

@lgritz
Copy link
Collaborator Author

lgritz commented May 5, 2024

Merging, since it fixes an OSL CI failure.

@lgritz lgritz merged commit 6ba496f into AcademySoftwareFoundation:master May 5, 2024
23 of 24 checks passed
@lgritz lgritz deleted the lg-clang18warn branch May 5, 2024 16:52
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request May 16, 2024
…n#4257)

This is a continuation of PR 4246, had one more spot where we needed to
disable warnings for unity builds involving clang18 and deprecated
unicode conversion functions.

There's some changes included to ci.yml and install_homebrew_deps.bash
that are part of work I did to make it easier for me to force it to use
clang-18 for certain tests while working on this.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request May 18, 2024
…n#4257)

This is a continuation of PR 4246, had one more spot where we needed to
disable warnings for unity builds involving clang18 and deprecated
unicode conversion functions.

There's some changes included to ci.yml and install_homebrew_deps.bash
that are part of work I did to make it easier for me to force it to use
clang-18 for certain tests while working on this.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant