Allow TypeDesc to be used directly in a C API by forcing it to be POD. #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Wilson <scott@propersquid.com>
|
I think there are a couple CI failures from compilers that don't accept static_assert in C++14 without the explanation string. (Don't worry about the "bleeding edge" test, that is failing because something is broken in the openexr trunk, it's not your fault.) |
|
No worries, will fix shortly. |
Signed-off-by: Scott Wilson <scott@propersquid.com>
lgritz
merged commit 43fea76
into
AcademySoftwareFoundation:master
24 of 25 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 1, 2024
…wareFoundation#4162) This PR is for allowing the TypeDesc type to be used directly in a C API without indirection, and therefore also in a Rust API without indirection. --------- Signed-off-by: Scott Wilson <scott@propersquid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Wilson scott@propersquid.com
Description
This PR is for allowing the TypeDesc type to be used directly in a C API without indirection, and therefore also in a Rust API without indirection.
Tests
I added static asserts for the TypeDesc so it should validate if the struct is okay at compile time.
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.