Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up after removing Findfmt.cmake #4103

Merged

Conversation

domin144
Copy link
Contributor

@domin144 domin144 commented Jan 7, 2024

Description

Remove duplicate dependecy for OpenImageIO_Util to fmt.
OpenImageIO target already depends on fmt through OpenImangeIO_Util library.

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

Remove duplicate dependecy for OpenImageIO_Util to fmt.

Signed-off-by: Dominik Wójt <domin144@o2.pl>
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit ae113fb into AcademySoftwareFoundation:master Jan 7, 2024
25 checks passed
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Jan 17, 2024
…on#4103)

Remove duplicate dependecy for OpenImageIO_Util to fmt.
OpenImageIO target already depends on fmt through OpenImangeIO_Util
library.


Signed-off-by: Dominik Wójt <domin144@o2.pl>
@domin144 domin144 deleted the remove_find_fmt_fix branch February 20, 2024 18:28
1div0 pushed a commit to 1div0/OpenImageIO that referenced this pull request Feb 24, 2024
…on#4103)

Remove duplicate dependecy for OpenImageIO_Util to fmt.
OpenImageIO target already depends on fmt through OpenImangeIO_Util
library.

Signed-off-by: Dominik Wójt <domin144@o2.pl>
Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants