ptex: support for static library #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments, only one kind of the library could be available. Choose proper fallback in such cases. Prefer static library, if LINKSTATIC is ON and dynamic otherwise. Signed-off-by: Dominik Wójt <domin144@o2.pl>
lgritz
merged commit 52f76f5
into
AcademySoftwareFoundation:master
24 of 25 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 10, 2023
In some environments, only one kind of the library could be available. Choose proper fallback in such cases. Prefer static library, if LINKSTATIC is ON and dynamic otherwise. Signed-off-by: Dominik Wójt <domin144@o2.pl>
1div0
pushed a commit
to 1div0/OpenImageIO
that referenced
this pull request
Feb 24, 2024
In some environments, only one kind of the library could be available. Choose proper fallback in such cases. Prefer static library, if LINKSTATIC is ON and dynamic otherwise. Signed-off-by: Dominik Wójt <domin144@o2.pl> Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some environments, only one kind of the library could be available.
Choose proper fallback in such cases. Prefer static library, if
LINKSTATIC is ON and dynamic otherwise.
Tests
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.