Move ARM_NEON definition and fix possible double define #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should not have been set in platform.h (inside the cpuid function!) in the first place. And apparently, though this was ok for Windows ARM, on Mac ARM it's an error because that symbol is already defined. So only redefine it if it's currently undefined. And move the whole check and definition into simd.h where all the other ARM_NEON stuff lives.
|
@mikaelsundell and @Gerdya does this look ok to both of you? |
|
Thanks for that, works on both my arm64 and x86_64 Mac builds.
Excellent support,
Mikael
Mikael Sundell
***@***.***
… On 3 Jan 2023, at 08:20, Larry Gritz ***@***.***> wrote:
@mikaelsundell <https://github.com/mikaelsundell> and @Gerdya <https://github.com/Gerdya> does this look ok to both of you?
—
Reply to this email directly, view it on GitHub <#3735 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEH2JW4EIPUKYL2W6SZXATWQPHMTANCNFSM6AAAAAATPMLYQ4>.
You are receiving this because you were mentioned.
|
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 3, 2023
…areFoundation#3735) It should not have been set in platform.h (inside the cpuid function!) in the first place. And apparently, though this was ok for Windows ARM, on Mac ARM it's an error because that symbol is already defined. So only redefine it if it's currently undefined. And move the whole check and definition into simd.h where all the other ARM_NEON stuff lives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not have been set in platform.h (inside the cpuid function!) in the first place. And apparently, though this was ok for Windows ARM, on Mac ARM it's an error because that symbol is already defined. So only redefine it if it's currently undefined. And move the whole check and definition into simd.h where all the other ARM_NEON stuff lives.