tiff updates for libtiff 4.5 #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libtiff 4.5 was just released, so confirm that we build against it, update the "latest versions" CI test to use 4.5. More careful sorting out of libtiff version numbers for conditional compilation. Get rid of some ancient tiff version guards that are related to libtiff versions that are older than we currently support. When building against libiff 4.5, use the new open calls that allow per-file error handlers, which is better than the old global error handlers for thread safety of multiple threads reading from the same ImageInput if there are errors. Convert error messages to std::format form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libtiff 4.5 was just released, so confirm that we build against it, update the "latest versions" CI test to use 4.5.
More careful sorting out of libtiff version numbers for conditional compilation.
Get rid of some ancient tiff version guards that are related to libtiff versions that are older than we currently support.
When building against libiff 4.5, use the new open calls that allow per-file error handlers, which is better than the old global error handlers for thread safety of multiple threads reading from the same ImageInput if there are errors.
Convert error messages to std::format form.