CMake: use of ${PROJECT_NAME} must be after call to project()
#3651
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
referenced
this pull request
Nov 4, 2022
Adapted from the similar document I wrote for OSL. This serves both as a checklist for me to make sure I don't miss any steps during a release, but also so that other people could take over release procedures if necessary or desired. I also rearranged the order of some lines in CMakeLists.txt for clarity (but did not change the logic).
|
LGTM |
|
I'll also backport to the release branch |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.