oiiotool: Add unit tests, minor internals utility refactoring #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a hidden --unittest command to oiiotool, only functional for Debug builds, which enables additional testing of internal utility funcions and other things that are difficult to fully exercise in the testsuite from normal oiiotool commands (could be done, but would take tons of additional tests to get into particular deep edge cases). Prototype by adding unit tests for scan_box. More will be added later now that the mechanism exists. Simplify string_to_dataformat Make sure to use --list-formats and --runstats during testing.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 19, 2022
…ySoftwareFoundation#3616) Add a hidden --unittest command to oiiotool, only functional for Debug builds, which enables additional testing of internal utility funcions and other things that are difficult to fully exercise in the testsuite from normal oiiotool commands (could be done, but would take tons of additional tests to get into particular deep edge cases). Prototype by adding unit tests for scan_box. More will be added later now that the mechanism exists. Simplify string_to_dataformat Make sure to use --list-formats and --runstats during testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hidden --unittest command to oiiotool, only functional for Debug builds, which enables additional testing of internal utility funcions and other things that are difficult to fully exercise in the testsuite from normal oiiotool commands (could be done, but would take tons of additional tests to get into particular deep edge cases).
Prototype by adding unit tests for scan_box. More will be added later now that the mechanism exists.
Simplify string_to_dataformat
Make sure to use --list-formats and --runstats during testing.