DDS: alpha/luminance format fixes, add & enable more tests #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While developing #3573 at one time I had them working properly, but then while fixing the address sanitizer failure for 3-channel formats I botched them again. Note to self: never again do a "yeah I'll add tests later", since if I had all of them running all the time this would not have happened. 🤦
With more test images recently added (#3459), start using them for DDS tests. This covers now: - Alpha, Luminance and Alpha+Luminance formats, - RGB formats with rarer channel sizes (rgb10 a2, r3g3b2), - Several "broken" DDS file cases - Removed usage of sample-DXT1 since it is well covered by others.
5 tasks
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 6, 2022
…ftwareFoundation#3581) * DDS: fixes for A8, L8, A8L8 formats While developing AcademySoftwareFoundation#3573 at one time I had them working properly, but then while fixing the address sanitizer failure for 3-channel formats I botched them again. Note to self: never again do a "yeah I'll add tests later", since if I had all of them running all the time this would not have happened. 🤦 * DDS: extend test coverage for more formats & channel size cases With more test images recently added (AcademySoftwareFoundation#3459), start using them for DDS tests. This covers now: - Alpha, Luminance and Alpha+Luminance formats, - RGB formats with rarer channel sizes (rgb10 a2, r3g3b2), - Several "broken" DDS file cases - Removed usage of sample-DXT1 since it is well covered by others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes A8, L8, L8A8 formats actually work now. While developing #3573 at one time I had them working properly, but then
while fixing the address sanitizer failure for 3-channel formats I botched them again. Note to self: never again do a "yeah I'll add tests later", since if I had all of them running all the time this would not have happened. 🤦
Tests
Extend test coverage for more formats & channel size cases. With more test images recently added (AcademySoftwareFoundation/OpenImageIO-images#5), start using them for DDS tests. This covers now:
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).