ustring hashing improvements #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
force-pushed
the
lg-ustringhasher
branch
3 times, most recently
from
4042051 to
9b3a99e
Compare
I realized that the recently added ustringhash class is confusingly similar to the (obscure, barely used, mostly forgotten) ustringHash functor. But also ustringHash doesn't need to exist, because it's equivalent to `std::hash<ustring>`, if we define it. So now we do define it, and also `std::hash<ustringhash>`, and deprecate ustringHash, to be removed entirely for 3.0. Also, add a ustring ctr from ustringhash (explicit only for now), and `operator<` for ustringhash. And add from_hash(size_t) method to ustringhash, analogous to ustring::from_hash(). Finally, modernize a few places we still used `(void)` to just `()`.
lgritz
force-pushed
the
lg-ustringhasher
branch
from
9b3a99e to
8791c53
Compare
rep_t is the type of the underlying representation (const char* for ustring, size_t for ustringhash). Modernize some typedef into using.
lgritz
force-pushed
the
lg-ustringhasher
branch
from
8791c53 to
5581fe1
Compare
AlexMWells
approved these changes
Oct 10, 2022
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 12, 2022
I realized that the recently added ustringhash class is confusingly similar to the (obscure, barely used, mostly forgotten) ustringHash functor. But also ustringHash doesn't need to exist, because it's equivalent to `std::hash<ustring>`, if we define it. So now we do define it, and also `std::hash<ustringhash>`, and deprecate ustringHash, to be removed entirely for 3.0. Also, add a ustring ctr from ustringhash (explicit only for now), and `operator<` for ustringhash. And add from_hash(size_t) method to ustringhash, analogous to ustring::from_hash(). Modernize a few places we still used `(void)` to just `()`. Give ustring and ustringhash a `using rep_t =` rep_t is the type of the underlying representation (const char* for ustring, size_t for ustringhash). Modernize some typedef into using. Make `==` and `!=(ustringhash, const char*)` be constexpr for C++ >= 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the recently added ustringhash class is confusingly similar to the (obscure, barely used, mostly forgotten) ustringHash functor. But also ustringHash doesn't need to exist, because it's equivalent to
std::hash<ustring>, if we define it. So now we do define it, and alsostd::hash<ustringhash>, and deprecate ustringHash, to be removed entirely for 3.0.Also, add a ustring ctr from ustringhash (explicit only for now), and
operator<for ustringhash.Finally, modernize a few places we still used
(void)to just().