Extract metadata from embedded ICC profiles. #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a while, we have found embedded ICC profiles in TIFF, JPEG, JPEG-2000, PNG, and PSD (PhotoShop) files and store them in the metadata as a byte array with the name "ICCProfile". With this patch, we further add the facility of parsing the binary ICC profile data to extract a number of other fields that we add to the ImageSpec metadata so that "oiiotool -info -v" or "iinfo 'v" will print this info. Important caveat: You can read this for informational purposes, but changing it (e.g. with spec.attribute()) does not change the contents of the ICCProfile byte array, which is still the canonical ground truth of the profile. You have to replace the "ICCProfile" byte array to actually change the profile.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 21, 2022
…on#3554) For a while, we have found embedded ICC profiles in TIFF, JPEG, JPEG-2000, PNG, and PSD (PhotoShop) files and store them in the metadata as a byte array with the name "ICCProfile". With this patch, we further add the facility of parsing the binary ICC profile data to extract a number of other fields that we add to the ImageSpec metadata so that "oiiotool -info -v" or "iinfo 'v" will print this info. Important caveat: You can read this for informational purposes, but changing it (e.g. with spec.attribute()) does not change the contents of the ICCProfile byte array, which is still the canonical ground truth of the profile. You have to replace the "ICCProfile" byte array to actually change the profile.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 6, 2022
…on#3554) For a while, we have found embedded ICC profiles in TIFF, JPEG, JPEG-2000, PNG, and PSD (PhotoShop) files and store them in the metadata as a byte array with the name "ICCProfile". With this patch, we further add the facility of parsing the binary ICC profile data to extract a number of other fields that we add to the ImageSpec metadata so that "oiiotool -info -v" or "iinfo 'v" will print this info. Important caveat: You can read this for informational purposes, but changing it (e.g. with spec.attribute()) does not change the contents of the ICCProfile byte array, which is still the canonical ground truth of the profile. You have to replace the "ICCProfile" byte array to actually change the profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, we have found embedded ICC profiles in TIFF, JPEG, JPEG-2000, PNG, and PSD (PhotoShop) files and store them in the metadata as a byte array with the name "ICCProfile".
With this patch, we further add the facility of parsing the binary ICC profile data to extract a number of other fields that we add to the ImageSpec metadata so that "oiiotool -info -v" or "iinfo 'v" will print this info.
Important caveat: You can read this for informational purposes, but changing it (e.g. with spec.attribute()) does not change the contents of the ICCProfile byte array, which is still the canonical ground truth of the profile. You have to replace the "ICCProfile" byte array to actually change the profile.