Redefinition of NOMINMAX causes warning in Windows

[DougRogers]

In platform.h for Windows, there is a definition of NOMINMAX that causes warnings when it is already defined.

//Avoid min and max being defined
#if defined(_WIN32)
#define NOMINMAX
#endif

Furthermore, right above it is another definition of NOMINMAX correctly wrapped by an ifdef

#if defined(_WIN32)
#    ifndef WIN32_LEAN_AND_MEAN
#        define WIN32_LEAN_AND_MEAN
#    endif
#    ifndef VC_EXTRALEAN
#        define VC_EXTRALEAN
#    endif
#    ifndef NOMINMAX
#        define NOMINMAX
#    endif
#    ifndef NOGDI
#        define NOGDI
#    endif
#    include <windows.h>
#endif

[lgritz]

Where exactly do you see the more complicated second one? I'm not seeing that in platform.h or anywhere else in the codebase.

[DougRogers]

Right below it

[DougRogers]

This is the current version in vcpkg. Version 2.4.14.0

[lgritz]

Aha, I see. That has been eliminated from master -- it was changed so we never directly include windows.h in platform.h.

I'll certainly fix it so that it doesn't do the #define if it's already been done, and do the full set of defines in the few places where we need windows.h.