PR: Update color_space_to_rgb_colourspace member usage in *OCIOView*.#1985
Merged
michdolan merged 1 commit intoAcademySoftwareFoundation:mainfrom Jun 24, 2024
Merged
Conversation
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
doug-walker
approved these changes
Jun 16, 2024
michdolan
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed updating some part of the code after accepting some inline suggestions during the Github review. This prevents OCIOView to start because of an import exception. I thought I had tested the branch fully but looks like I did not. This fixes the issue and I double-checked this time!
Thanks to mmdanggg2 for the report.