Fix prefilter env tangent-frame seam and add mx_isinf wrapper - #3023
Merged
jstone-lucasfilm merged 2 commits intoAug 11, 2026
Conversation
Fixes a tangent-frame seam in mx_generate_prefilter_env by building the frame from the latlong parameterization instead of calling mx_orthonormal_basis, which flips discontinuously where N.z crosses zero at longitude ±90°. Also adds an mx_isinf wrapper to the GLSL/MSL/Slang math libraries and updates mx_chiang_hair_bsdf.glsl to use it. This is requried because wgsl does not support it. Validated with before/after GLSL renders using --envMethod 1 (prefiltered environment maps).
jstone-lucasfilm
approved these changes
Aug 11, 2026
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
Thanks for these improvements, @ashwinbhat!
jstone-lucasfilm
merged commit Aug 11, 2026
a7b2d60
into
AcademySoftwareFoundation:main
70 of 71 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a tangent-frame seam in mx_generate_prefilter_env by building the frame from the latlong parameterization instead of calling mx_orthonormal_basis, which flips discontinuously where N.z crosses zero at longitude ±90°.
Also adds an mx_isinf wrapper to the GLSL/MSL/Slang math libraries and updates mx_chiang_hair_bsdf.glsl to use it. This is required because wgsl does not support it.
Validated with before/after GLSL renders using --envMethod 1 (prefiltered environment maps).
mx_orthonormal_basis_comparison.html.pdf