Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for imagePullSecrets into helm chart #47

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Add support for imagePullSecrets into helm chart #47

merged 3 commits into from
Jun 7, 2021

Conversation

somaritane
Copy link

@somaritane somaritane commented Jun 4, 2021 •
edited
Loading

Add support for imagePullSecrets into terraform-controller helm chart.
The example settings in custom values.yaml might look like:

# values.yaml:
global:
  imagePullSecrets:
  # list of image pull secrets alike to specified in a pod or service account spec
  - name: regcred

Signed-off-by: Timofey Ilinykh timofey.ilinykh@absa.africa

@somaritane somaritane requested a review from k0da June 4, 2021 10:53
k0da
k0da requested changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is worth to set particular cred into global chart values

@somaritane
Copy link
Author

I don't think it is worth to set particular cred into global chart values

I've got inspired by https://github.com/k8gb-io/k8gb/blob/master/chart/k8gb/templates/service_account.yaml here :)
When you add imagePullSecrets to a ServiceAccount, that affects all the images deployed by that ServiceAccount, hence I thought it also makes sense to put them to the global section in values.yaml.
But I don't have a strong opinion about this, can move them under the image: section.

k0da
k0da previously approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad.

Was confused by initial comment. I had an impression you going to put regcred into values.yaml

LGTM

k0da
k0da previously approved these changes Jun 4, 2021
View reviewed changes
Timofey Ilinykh added 3 commits June 7, 2021 12:38
Add support for imagePullSecrets into helm chart
a760565 
Add support for imagePullSecrets into terraform-controller helm chart:

```yaml
# values.yaml:
global:
  imagePullSecrets:
  # list of image pull secrets alike to specified in a pod or service account spec
  - name: regred
```

Signed-off-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
Small typo fix
91e67d9 
Signed-off-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
remove extra empty line
1b61a68 
Signed-off-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
@somaritane somaritane force-pushed the helm-image-pull-secrets branch from 3637e46 to 1b61a68 Compare June 7, 2021 10:40
@somaritane somaritane merged commit 2c7c1b9 into master Jun 7, 2021
@somaritane somaritane deleted the helm-image-pull-secrets branch June 7, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somaritane @k0da