Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for env vars to controller helm chart #44

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

somaritane
Copy link

Add support for environment variables to terraform controller helm chart.
Variables can be set as a map in the values.yaml env: section, e.g.:

env:
    DEBUG: "true"

and can be manually overridden via helm cli, e.g. --set env.DEBUG=true

Signed-off-by: Timofey Ilinykh timofey.ilinykh@absa.africa

Add support for environment variables to terraform controller helm chart.
Variables can be set as a map in the `values.yaml` `env:` section, e.g.:
```
env:
    DEBUG: "true"
```
and can be manually overridden via helm cli, e.g. `--set env.DEBUG=true`

Signed-off-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
@somaritane somaritane requested a review from k0da June 2, 2021 22:33
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somaritane somaritane merged commit d7aaaa0 into master Jun 3, 2021
@somaritane somaritane deleted the chart-env-var-support branch June 3, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants