Conversation
…ring in promote_alerts.py
…ues based on child issue creation
… to label orphan child issues for closure
…ng labels on issue close
Zejnilovic
left a comment
There was a problem hiding this comment.
I did a 1st pass on the workflows. Checking logic and flow.
.github/workflows/aquasec-scan.yml
Outdated
| - name: Set up Python | ||
| uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 | ||
| with: | ||
| python-version: '3.11' |
There was a problem hiding this comment.
We like to use python 3.14, if we can.
.github/workflows/aquasec-scan.yml
Outdated
| GH_TOKEN: ${{ github.token }} | ||
| TEAMS_WEBHOOK_URL: ${{ secrets.TEAMS_WEBHOOK_URL }} | ||
| run: | | ||
| org-workflows/github/security/run-all.sh |
There was a problem hiding this comment.
I don't think that run-all.sh is a good naming for script. As a reader, I can not know, what means all. I would rename the script.
| # Called from application repositories via workflow_call. | ||
| # The caller must trigger on `issues: [closed]` and forward the event context. | ||
|
|
||
| name: Remove sec:adept-to-close on close |
There was a problem hiding this comment.
We use capital first letters in the workflow naming. I would also add a label in the name for better understanding.
There was a problem hiding this comment.
Addressed in 4523867.
decision: we will use only lower case labels.
|
|
||
| jobs: | ||
| scan: | ||
| uses: AbsaOSS/organizational-workflows/.github/workflows/aquasec-scan.yml@master |
tmikula-dev
left a comment
There was a problem hiding this comment.
I had a time to look at first three workflow files, please react to my comments.
…h to sync_security_alerts.sh/
Zejnilovic
left a comment
There was a problem hiding this comment.
2nd pass. I expect to do 1 more max.
… in sync_security_alerts.sh
…lerts.sh for consistency
…NER and REPO_NAME variables
Release Notes:
Closes https://github.com/absa-group/cps-qa/issues/121