Skip to content

Pilot solution.#1

Merged
miroslavpojer merged 30 commits intomasterfrom
feature/add-logic-or-alter-to-issue-sync
Feb 18, 2026
Merged

Pilot solution.#1
miroslavpojer merged 30 commits intomasterfrom
feature/add-logic-or-alter-to-issue-sync

Conversation

@miroslavpojer
Copy link
Contributor

@miroslavpojer miroslavpojer commented Feb 10, 2026

Release Notes:

  • Added Microsoft Teams notifications for newly created or reopened security child issues (via Incoming Webhook / Adaptive Card).
  • Added send_to_teams.py CLI helper to post Markdown messages to Teams (supports stdin/file, dry-run, title/subtitle).
  • Improved promote_alerts.py issue sync logic with category persistence via secmeta and cleaner Teams message formatting.
  • Hardened GitHub CLI state changes with multi-strategy fallback (supports older gh versions without --state).
  • Fixed timezone-safe date handling by replacing deprecated datetime.utcnow() usage.
  • Removed unused/dead code paths and simplified data structures (including removing the unused title field from NotifiedIssue).
  • Added check_labels.py to validate required repository labels exist before running automation.
  • Enhanced run-all.sh to include label checks, add flags for Teams webhook forwarding, and provide a skip-label-check option.
  • Introduced reusable GitHub Actions workflows for security automation (shared workflows under workflows).
  • Added example caller workflows under worklows for easy adoption by application repositories.
  • Added documentation improvements in the security README, including a table of contents and expanded shared-workflow adoption guidance.

Closes https://github.com/absa-group/cps-qa/issues/121

@miroslavpojer miroslavpojer self-assigned this Feb 10, 2026
Copy link
Collaborator

@HuvarVer HuvarVer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen the changes

@miroslavpojer miroslavpojer changed the title Inital data population. Development wil follow Initial data population. Development will follow Feb 12, 2026
@miroslavpojer miroslavpojer changed the title Initial data population. Development will follow Pilot solution. Feb 12, 2026
@miroslavpojer miroslavpojer marked this pull request as ready for review February 12, 2026 15:16
Copy link
Collaborator

@Zejnilovic Zejnilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a 1st pass on the workflows. Checking logic and flow.

- name: Set up Python
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548
with:
python-version: '3.11'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like to use python 3.14, if we can.

GH_TOKEN: ${{ github.token }}
TEAMS_WEBHOOK_URL: ${{ secrets.TEAMS_WEBHOOK_URL }}
run: |
org-workflows/github/security/run-all.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that run-all.sh is a good naming for script. As a reader, I can not know, what means all. I would rename the script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 4523867.

# Called from application repositories via workflow_call.
# The caller must trigger on `issues: [closed]` and forward the event context.

name: Remove sec:adept-to-close on close
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use capital first letters in the workflow naming. I would also add a label in the name for better understanding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 4523867.
decision: we will use only lower case labels.


jobs:
scan:
uses: AbsaOSS/organizational-workflows/.github/workflows/aquasec-scan.yml@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add here a TODO comment, so we do not forget a spot, where we have to change the @master later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in e57356e.

Copy link
Collaborator

@tmikula-dev tmikula-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a time to look at first three workflow files, please react to my comments.

Copy link
Collaborator

@Zejnilovic Zejnilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd pass. I expect to do 1 more max.

@miroslavpojer miroslavpojer merged commit b5b6caf into master Feb 18, 2026
@miroslavpojer miroslavpojer deleted the feature/add-logic-or-alter-to-issue-sync branch February 18, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants