Merged
Conversation
|
Report: Report: api - scala:2.12.17
|
jakipatryk
reviewed
Oct 22, 2025
Collaborator
jakipatryk
left a comment
There was a problem hiding this comment.
Looks good overall, just these "`case-sensitive`" backquote-based arguments name looks weird and I personally prefer to not use them unless a Java library is used which forces us to have them, for example to adhere to an interface.
…itive` is left in the URL
jakipatryk
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally with
/token/generate?group-prefixes=prefix1,PREFIX2,PREFiX3, the prefixes were always case-sensitive. This proved to be less than ideal.Newly, there is a optional param
case-sensitive=true|false(default:falseif not given) that governs how group prefixes filtering is done.Release notes:
/token/generate?group-prefixes=prefixHereis no longer case-sensitive by default. One may add&case-sensitive=trueto bring back previous behavior.Closes #146
Migration notes:
Login service v1.6.0 and older's
/token/generate?group-prefixes=prefixesHereequivalent will now be/token/generate?group-prefixes=prefixesHere&case-sensitive=true