(#129) ls pwd rotation support

[TheLydonKing]

Release Notes:

• Added Option for AWS SSM Paramter Store as alternative to AWS Secrets manager for storing credentials
• Updated Tests to support the new addition
• Updated ReadMe to indicate how to implement.

[github-actions]

Report: Report: api - scala:2.12.17

Metric (instruction)	Coverage	Threshold	Status
Overall	68.71%	43.0%	✅
Changed Files	45.03%	70.0%	❌

File Path	Coverage	Threshold	Status
AwsSecretsUtils.scala	0.0%	0.0%	✅
AwsSsmUtils.scala	69.66%	0.0%	✅
ServiceAccountConfig.scala	65.44%	0.0%	✅

[dk1844]

I originally wondered if no mention of "parameter store" is an issue, but looking at how the AWS API is named, it makes sense that "SSM" and "getParameter" makes this clear enough.

Nicely done, just please add some of the tests suggested below if possible

[dk1844]

I like the fact that you made it more configurable than other internal tools that can rely more directly on how the username+password fields are, this is welcome for an OSS project!

[dk1844]

Sorry for bashing, but let's use mocking instead of custom-tailored TestClass implementation approach

[dk1844]

LGTM

(the thenAnswer/thenReturn difference is a small thing not blocking merge in my view)

[dk1844]

Why have you decided to complicate with thenAnswer? (multiple places)

I mean:
when(...).thenAnswer(_ => ...) when the simpler when(...).thenResult(...) would have sufficed.

But at least I learned a bit more about thenAnswer (I have not used that that much before).

Suggested change

	.thenAnswer(_ =>
	Some(AwsSecret(Map(
	"accountName" -> "ldap-user123",
	"accountPwd" -> "password456"),
	Instant.now())))
	.thenResult(
	Some(AwsSecret(Map(
	"accountName" -> "ldap-user123",
	"accountPwd" -> "password456"),
	Instant.now())))

[TheLydonKing]

I wasn't aware of .thenResult as the practice I've had withMockito only used .theAnswer.

Will keep it in mind for future.