Skip to content

Improve workflow content #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

miroslavpojer
Copy link
Collaborator

  • Refactored release_draft.yml file content. Improved tag control logic.

@miroslavpojer miroslavpojer self-assigned this Oct 9, 2024
@miroslavpojer
Copy link
Collaborator Author

Release notes:

  • Improve logic controlling tag creation.

@miroslavpojer miroslavpojer requested a review from benedeki October 9, 2024 10:29

const latestTag = refs.sort((a, b) => new Date(b.object.date) - new Date(a.object.date))[0].ref.replace('refs/tags/', '');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. Don't sort by date but by version expression. (if you are changing it)

{"title": "New Features 🎉", "label": "enhancement"},
{"title": "Bugfixes 🛠", "label": "bug"}
]
chapters: '[
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the array a string?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in Issue ##85.

Copy link

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it will work. 😉

@miroslavpojer miroslavpojer merged commit d5c5b70 into master Oct 9, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/fix-tag-control-logic branch October 9, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants