Skip to content

Feature/66 introduce logging config #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Sep 2, 2024

Conversation

miroslavpojer
Copy link
Collaborator

  • Add new setup method and module for logging.
  • Refactored all modules and logging calls.

Closes #66

- Added pylint config. Reused config from living-documentation-generator repository as approved settings.
- Add section in README.md describing how to use pylint.
- Add new library dependency into requirements.txt
- Updated test.yml file (renamed from build.yml) to run two jobs: unit test and static code analysis. Job for static code analysis contains check for minimal required scode == 9.5.
- Formatting of repository code will part of following Issue.
- Update of Readme and fix the TOC.
- Add new setup method and module for logging.
- Refactored all modules and logging calls.
@miroslavpojer miroslavpojer self-assigned this Aug 30, 2024
@miroslavpojer
Copy link
Collaborator Author

Release notes:

  • Add a new setup method and module for logging.
  • Refactored all modules and logging calls.

…nfig

# Conflicts:
#	.github/workflows/test.yml
#	main.py
#	release_notes_generator/action_inputs.py
#	release_notes_generator/builder.py
#	release_notes_generator/generator.py
#	release_notes_generator/model/record.py
#	release_notes_generator/record/record_factory.py
#	release_notes_generator/utils/decorators.py
#	release_notes_generator/utils/github_rate_limiter.py
#	requirements.txt
Copy link

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand it correctly the issue was with not having a Handler, which caused not logging into CI.

@miroslavpojer
Copy link
Collaborator Author

If I understand it correctly the issue was with not having a Handler, which caused not logging into CI.

Yes, from the experiment, this was the source of problems.

@MobiTikula MobiTikula self-requested a review September 2, 2024 12:42
@miroslavpojer miroslavpojer merged commit b1e57df into master Sep 2, 2024
3 checks passed
@miroslavpojer miroslavpojer deleted the feature/66-Introduce-logging-config branch September 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce logging config
2 participants