Skip to content

Add Service chapter visibility control #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

miroslavpojer
Copy link
Collaborator

  • Clean up of action controls to manage service chapters visibility.
  • Grouped "features" controls.
  • Simplified the code using static ActionInputs.
  • Introduced defaults values in ActionInputs and env variable access methods.
  • Updated unit tests.

Closes #52

- Grouped "features" controls.
- Simplified the code using static ActionInputs.
- Introduced defaults values in ActionInputs and env variable access methods.
- Updated unit tests.
@miroslavpojer
Copy link
Collaborator Author

Release notes:

  • Clean up of action controls to manage service chapters visibility.
  • Grouped "features" controls.
  • Simplified the code using static ActionInputs.
  • Introduced defaults values in ActionInputs and env variable access methods.
  • Updated unit tests.

Copy link

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md
line 268: python3 ./<path-to-action-project-root>/main.py = I think there should be a dot before setting the path to action project root.
GENERATOR
line 20: from github import Github, Auth = extra Auth module

There are code formatting issues, but will be probably part of formatting issue.

@miroslavpojer
Copy link
Collaborator Author

README.md line 268: python3 ./<path-to-action-project-root>/main.py = I think there should be a dot before setting the path to action project root. GENERATOR line 20: from github import Github, Auth = extra Auth module

There are code formatting issues, but will be probably part of formatting issue.

README.md line 268: python3 ./<path-to-action-project-root>/main.py = I think there should be a dot before setting the path to action project root. GENERATOR line 20: from github import Github, Auth = extra Auth module

There are code formatting issues, but will be probably part of formatting issue.

Addressed in commit bb2e565.

- Update of doc string format. Removed no more present parameter.
@miroslavpojer miroslavpojer self-assigned this Aug 26, 2024
@miroslavpojer miroslavpojer merged commit 828c5c7 into master Aug 26, 2024
2 checks passed
@miroslavpojer miroslavpojer deleted the feature/52-Add-logic-to-control-the-visibility-of-Service-chapters branch August 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logic to control the visibility of Service chapters
2 participants