#43: Upgrade Slick version and add Slick-pg dependency #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added Slick-pg
* Introduced slick-pg optional dependency to increase the number of supported types * created a Slick profile to use the Slick-pg types (most of them) * added implicits to use with UUID type * `SlickPgFunction` and `SlickPgFunctionWithStatusSupport` traits were renamed to `SlickFunction` and `SlickFunctionWithStatusSupport`as they are not really Postgres dependent * added new alternative constructor to `DBSchema` and `DBFunction` * extended `README.md` to contain info on Slick module
benedeki
requested review from
Zejnilovic,
dk1844,
jakipatryk,
lsulak and
miroslavpojer
JaCoCo code coverage report - scala 2.11.12
|
JaCoCo code coverage report - scala 2.12.17
|
benedeki
added
the
dependent
…test (#46) * test for `FaDbPostgresProfile` * test changed into integration test * added test for NULL/Option verification of types * fixed Option[UUID] parameter setting
benedeki
removed
the
dependent
Contributor
Author
|
This item depends on: |
jakipatryk
previously approved these changes
Jun 30, 2023
Contributor
jakipatryk
left a comment
jakipatryk
left a comment
There was a problem hiding this comment.
LGTM (just checked the code).
slick/src/it/scala/za/co/absa/fadb/slick/FaDbPostgresProfileSuite.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: jakipatryk <bajbartlomiej997@gmail.com>
jakipatryk
approved these changes
Jun 30, 2023
miroslavpojer
approved these changes
Jun 30, 2023
benedeki
deleted the
feature/43-upgrade-slick-version-and-add-slick-pg-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlickPgFunctionandSlickPgFunctionWithStatusSupporttraits were renamed toSlickFunctionandSlickFunctionWithStatusSupportas they are not really Postgres dependentDBSchemaandDBFunctionREADME.mdto contain info on Slick moduleKept the Slick version as is, as it's the last one supporting Scala 2.11 and now is not the time to deal with version juggling. For same reason the Slick-pg is also not the latest version, but the one built for the used Slick
Depends on #46
Closes #43