Add support for new test topic and improve error logging in writers#49
Merged
oto-macenauer-absa merged 2 commits intomasterfrom Sep 5, 2025
Merged
Add support for new test topic and improve error logging in writers#49oto-macenauer-absa merged 2 commits intomasterfrom
oto-macenauer-absa merged 2 commits intomasterfrom
Conversation
petr-pokorny-absa
previously approved these changes
Sep 5, 2025
petr-pokorny-absa
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new
public.cps.za.testtopic across the configuration, schema, and writers, and adds a comprehensive configuration validation test suite. The changes ensure that the new topic is handled end-to-end, while also improving error logging in writer modules and enforcing config/schema correctness with new tests.Support for new topic
public.cps.za.test:public.cps.za.testtopic with associated user access inconf/access.json.conf/topic_test.json.src/event_gate_lambda.pyto load the new topic schema and switched config loading toconfig.dev.json.Writer enhancements for the new topic:
postgres_test_writefunction insrc/writer_postgres.pyto handle inserts for the new topic, and updated the main write logic to support it [1] [2].Improved error logging:
src/writer_eventbridge.py,src/writer_kafka.py, andsrc/writer_postgres.pyto provide more context on unknown exceptions [1] [2] [3].Configuration and schema validation tests:
tests/test_conf_validation.pyto verify that config files contain required keys, access files have correct structure, and topic schemas are well-formed.Release notes
Release notes:
Related work
Closed #48