Fix linting errors across the app (ToolJet#785)

* eslint-setup: rules for frontend and server

* setup pre-commit:hook

* frontend:eslint fixes

* frontend eslint errors and warning fixed

* eslint:fix for ./server

* fix server/test: expectatin string lint/error

* pre-commit:updated

* removed unwanted install cmd from docker file

* recommended settings and extension for vscode

* husky prepare script added

* updated extension recommendations

* added prettier as recommended extension

* added pre-commit to package.json

* remove .prettierrc file

* resolve changes

* resolve changes

.vscode/extension.json

@@ -0,0 +1,11 @@
+{
+    "recommendations": [
+      "dbaeumer.vscode-eslint",
+      "CoenraadS.bracket-pair-colorizer",
+      "mgmcdermott.vscode-language-babel",
+      "formulahendry.auto-rename-tag",
+      "xabikos.javascriptsnippets",
+      "streetsidesoftware.code-spell-checker",
+      "esbenp.prettier-vscode"
+    ]
+}

.vscode/settings.json

@@ -0,0 +1,14 @@
+{
+    "[javascript, typescript]": {
+        "editor.defaultFormatter": "dbaeumer.vscode-eslint",
+    },
+    "eslint.validate": [
+        "javascript",
+        "javascriptreact",
+        "typescript",
+        "typescriptreact"
+    ],
+    "eslint.format.enable": true,
+    "editor.formatOnSave": true,
+
+}

docker/client.Dockerfile.dev

@@ -12,6 +12,7 @@ ENV PATH /app/node_modules/.bin:$PATH
 # Fix for heap limit allocation issue
 ENV NODE_OPTIONS="--max-old-space-size=2048"
 
+
 # install app dependencies
 COPY package.json package-lock.json  ./
 RUN npm install

frontend/.eslintrc.json

@@ -0,0 +1,56 @@
+{
+    "env": {
+      "browser": true,
+      "amd": true,
+      "es2021": true
+    },
+    "extends": [
+      "eslint:recommended",
+      "plugin:react/recommended",
+      "plugin:react-hooks/recommended",
+      "plugin:import/errors",
+      "plugin:import/warnings",
+      "plugin:prettier/recommended",
+      "plugin:cypress/recommended"
+    ],
+    "parser": "babel-eslint",
+    "parserOptions": {
+      "ecmaFeatures": {
+        "jsx": true
+      },
+      "ecmaVersion": 12,
+      "sourceType": "module"
+    },
+    "plugins": ["react", "prettier"],
+    "rules": {
+      "prettier/prettier": [
+        "error",
+        {
+          "semi": true,
+          "trailingComma": "es5",
+          "printWidth": 120,
+          "singleQuote": true,
+          "arrowParens": "always",
+          "proseWrap": "preserve"
+        }
+      ],
+      "react/prop-types": 0,
+      "react/display-name": "off",
+      "no-unused-vars": [2, { "args": "after-used", "argsIgnorePattern": "reject" }],
+      "react/no-deprecated": 0,
+      "no-prototype-builtins": 0
+    },
+    "settings": {
+      "react": {
+        "version": "detect"
+      },
+      "import/resolver": "webpack"
+    },
+    "globals": {
+      "fetch": true,
+      "process": true,
+      "module": true,
+      "__dirname": true
+    }
+}
+

frontend/cypress/plugins/index.js

@@ -1,16 +1,12 @@
-const webpackPreprocessor = require('@cypress/webpack-preprocessor')
-
 module.exports = (on, config) => {
   if (config.testingType === 'component') {
-    const { startDevServer } = require('@cypress/webpack-dev-server')
+    const { startDevServer } = require('@cypress/webpack-dev-server');
 
     // Your project's Webpack configuration
-    const webpackConfig = require('../../webpack.config.js')
+    const webpackConfig = require('../../webpack.config.js');
 
-    on('dev-server:start', (options) =>
-      startDevServer({ options, webpackConfig })
-    )
+    on('dev-server:start', (options) => startDevServer({ options, webpackConfig }));
   }
 
-  return config
-}
+  return config;
+};

frontend/cypress/support/index.js

@@ -14,7 +14,7 @@
 // ***********************************************************
 
 // Import commands.js using ES2015 syntax:
-import './commands'
+import './commands';
 
 // Alternatively you can use CommonJS syntax:
 // require('./commands')