This repository was archived by the owner on Oct 10, 2024. It is now read-only.
Replace videoWidth, videoHeight with VideoResizer interface #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this library and wanted to set a maximum resolution for videos however that is currently not possible. When overriding the default resize function by adding
videoWidthandvideoHeightto the configuration, this resizes the video to those dimensions exactly. In my case this means that the video is stretched to a 1:1 aspect ratio, and lower resolution videos are upscaled.I've added a functional interface
VideoResizerthat allows a custom function to calculate the desired dimension using the source video's dimensions, with some default implementations:VideoResizer.auto- Matches the original behavior when not providingvideoWidthandvideoHeightin the configurationVideoResizer.scale- Scale the dimensions by a scale factorVideoResizer.limitSize- Set a maximum width and height value for the videoVideoResizer.matchSize- Set an exact width and height valueI've updated the
Configurationclass and replacedkeepOriginalResolution,videoWidthandvideoHeightwithresizer, and added a constructor overload to match the old behaviour.