renamed DocumentSplitter split() to splitAll() (langchain4j#50)

AbdullahGheith · Jul 25, 2023 · 5666328 · 5666328
1 parent 6e240e4
commit 5666328
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/langchain4j-core/src/main/java/dev/langchain4j/data/document/DocumentSplitter.java b/langchain4j-core/src/main/java/dev/langchain4j/data/document/DocumentSplitter.java
@@ -10,7 +10,7 @@ public interface DocumentSplitter {
 
     List<TextSegment> split(Document document);
 
-    default List<TextSegment> split(List<Document> documents) {
+    default List<TextSegment> splitAll(List<Document> documents) {
         return documents.stream()
                 .flatMap(document -> split(document).stream())
                 .collect(toList());

diff --git a/langchain4j/src/main/java/dev/langchain4j/store/embedding/EmbeddingStoreIngestor.java b/langchain4j/src/main/java/dev/langchain4j/store/embedding/EmbeddingStoreIngestor.java
@@ -41,7 +41,7 @@ public void ingest(Document... documents) {
     }
 
     public void ingest(List<Document> documents) {
-        List<TextSegment> segments = splitter.split(documents);
+        List<TextSegment> segments = splitter.splitAll(documents);
         List<Embedding> embeddings = embeddingModel.embedAll(segments);
         embeddingStore.addAll(embeddings, segments);
     }

diff --git a/langchain4j/src/test/java/dev/langchain4j/store/embedding/EmbeddingStoreIngestorTest.java b/langchain4j/src/test/java/dev/langchain4j/store/embedding/EmbeddingStoreIngestorTest.java
@@ -29,7 +29,7 @@ public void should_split_documents_then_embed_them_and_store_in_embedding_store(
                 textSegment("Second sentence."),
                 textSegment("Third sentence.")
         );
-        when(splitter.split(documents)).thenReturn(segments);
+        when(splitter.splitAll(documents)).thenReturn(segments);
 
         EmbeddingModel embeddingModel = mock(EmbeddingModel.class);
         List<Embedding> embeddings = asList(
@@ -51,7 +51,7 @@ public void should_split_documents_then_embed_them_and_store_in_embedding_store(
         ingestor.ingest(documents);
 
 
-        verify(splitter).split(documents);
+        verify(splitter).splitAll(documents);
         verifyNoMoreInteractions(splitter);
 
         verify(embeddingModel).embedAll(segments);