Vscode diff visualize #539
Conversation
PCSwingle
force-pushed
the
vscode-diff-visualize
branch
from
070e683 to
d2af7cb
Compare
There was a problem hiding this comment.
General things:
In the README, line 27 should say pip install -e (not 3), and line 28 should be ~/.mentat/.venv (not ~/mentat).
I almost never see the accept/reject/preview buttons in vscode, not sure why. This is how it normally looks:
Also sometimes if there's text between two file_edits that gets rendered as part of the code block.
| @@ -9,6 +9,10 @@ import { StreamMessage } from "types"; | |||
| import * as util from "util"; | |||
| import { v4 } from "uuid"; | |||
| import * as vscode from "vscode"; | |||
|
|
|||
| // IMPORTANT: This MUST be updated with the vscode extension to ensure that the right mentat version is installed! | |||
| const MENTAT_VERSION = "1.0.10"; | |||
There was a problem hiding this comment.
Seems like someone (me) will forget to do this, any reason not to grab it programmatically from mentat/mentat/VERSION? Or maybe just always to pip --upgrade below?
There was a problem hiding this comment.
Oh hmm that would be a better idea to grab it from mentat/metnat/version; i'll do that. The reason we can't pip --upgrade is because I don't want to have to worry about backwards compatibility; this way, if somebody is using an older version of the extension it will automatically install the compatible version of mentat.
There was a problem hiding this comment.
I think I'll add a build step that injects the version from mentat/mentat/version into the extension in another PR. I haven't messed with the build steps too much yet and it isn't really necessary right now.
|
|
||
| conversation.clear_messages() | ||
| code_context.clear_auto_context() |
There was a problem hiding this comment.
I think we should either clear all the context, or reset your manually-included context. Especially now that auto-context is cumulative, a /clear command doesn't really make sense unless it resets the context too.
There was a problem hiding this comment.
The point of /clear is to remove all the messages; you can still /exclude * if you want to exclude all files.
| console.log("Installed Mentat"); | ||
| } | ||
|
|
||
| return binFolder; | ||
| } | ||
|
|
||
| private collectConfigOptions(): string[] { | ||
| const configuration = vscode.workspace.getConfiguration("mentat"); | ||
| const optionNames = [ |
There was a problem hiding this comment.
Eventually these could be enumerated in types and built programmatically, seen it a few places.
There was a problem hiding this comment.
Agreed it would be a lot nicer. Seeing as we have to manually add the config options to the package.json right now anyways though I think we can hold off on this for a bit.
I couldn't repro on linux, I assume it's a mac issue; I'll try and see if I can repro when I next have the chance to use a mac.
Fixed this. Thanks! |
Pull Request Checklist