Active diff snapshot not automatically run #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not very safe to be messing with git at startup. There are a lot of edge cases. Most users won't use the sampler at all and even with this change the sampler will still work well assuming the changes being made aren't related to the active diff.
biobootloader
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Feel free to merge as this fixes user issue, but @granawkins what are your thoughts?
|
The user said they had a workaround with .gitignore. I'll wait to merge until Grant's seen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not very safe to be messing with git at startup. There are a lot of edge cases. Most users won't use the sampler at all and even with this change the sampler will still work well assuming the changes being made aren't related to the active diff.
Pull Request Checklist