Add AutoCreate option #28
Conversation
This flag allows unknown repositories to be automatically created on push or pull
|
Apologies for the drive-by PR. This functionality is useful to me so I added it in, thought I'd create the PR as a courtesy in case it might also be useful to the project authors. Feel free to merge if useful or close if not. Cheers for creating and publishing the library. Much appreciated! |
dmitshur
left a comment
dmitshur
left a comment
There was a problem hiding this comment.
I wanted to share one comment related to the code style.
| GitBinPath: "/usr/bin/git", | ||
| UploadPack: true, | ||
| ReceivePack: true, | ||
| AutoCreate: false, |
There was a problem hiding this comment.
From a Go style perspective, given that false is already the zero value for bool, it might make sense to omit it instead of explicitly setting it to false here.
|
Thanks for the style tip. I'm still reasonably new to Go so getting the hang of the idioms. On taking a closer look at the other open PRs on the repo it looks like the functionality I'm adding here is actually a subset of #21 which itself is a subset of #27. This functionality could be implemented as a custom function passed to either one of those variants. |
2 participants
This flag allows unknown repositories to be automatically created on push or pull