Skip to content

auth: Suggestion, use standard library to parse basic auth header. #12

@dmitshur

Description

@dmitshur

Hi,

This is just a suggestion. The file auth/basicauth.go contains func parseAuthHeader(header string) (*BasicAuth, error) to parse basic authentication header.

This functionality is available a part of the Go standard library:

https://godoc.org/net/http#Request.BasicAuth

You could use that instead. That'll allow you to completely remove auth/basicauth.go and its tests.

What do you think of that idea?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions