Copy symbolic errors when composing #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
force-pushed
the
gh-87-symbolic
branch
from
e660060 to
098e4c6
Compare
|
Another one for you to review, @AaronLasseigne. This suffers from the same problems mentioned in #194 (comment), but I think the tradeoffs are worth it. I think #245 could provide a better long-term solution for this. I don't want to let perfect be the enemy of good, though. |
|
It looks good and what we currently do is (as you pointed out) not very good. I think we just need to mention some of these sharp edges in the docs. |
|
Should I add that to the "Errors" section or the "Composition" section? |
|
Probably the "Errors" section and then link to it from the "Composition" section. Does that sound reasonable? |
|
👍 |
tfausak
force-pushed
the
gh-87-symbolic
branch
from
b10c1dc to
b804eba
Compare
|
I updated the documentation. |
|
|
|
This is a breaking change, so it'll need to be merged into a branch for v3.0.0. |
|
True. |
Closed
tfausak
added a commit
that referenced
this pull request
Jan 10, 2016
Copy symbolic errors when composing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87.