Compilation errors with clang19 when compiling the simple sample program

[MartinBourbier]

Clang version:

Debian clang version 19.1.4 (1~deb12u1)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-19/bin

CMake output:

42sh$ CXX="$(which clang++-19)" cmake -B build
-- The CXX compiler identification is Clang 19.1.4
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++-19 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/g704120/cxx_tuncfest/samples/simple/build

Make output

42sh$ make -C build/
make: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[1]: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[2]: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[2]: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[2]: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
[ 50%] Building CXX object CMakeFiles/main.dir/main.cc.o
In file included from /home/g704120/cxx_tuncfest/samples/simple/main.cc:1:
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:257:28: error: variable has incomplete type 'struct winsize'
  257 |             struct winsize w;
      |                            ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:257:20: note: forward declaration of 'winsize'
  257 |             struct winsize w;
      |                    ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:258:34: error: use of undeclared identifier 'TIOCGWINSZ'
  258 |             ioctl(STDOUT_FILENO, TIOCGWINSZ, &w);
      |                                  ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:265:17: error: implicit instantiation of undefined template 'std::tuple<unsigned char, unsigned char, unsigned char>'
  265 |                 start_color = { 227, 52, 0 },
      |                 ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_pair.h:90:11: note: template is declared here
   90 |     class tuple;
      |           ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:265:17: note: passing argument to parameter 'start_color' here
  265 |                 start_color = { 227, 52, 0 },
      |                 ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:267:17: error: implicit instantiation of undefined template 'std::tuple<unsigned char, unsigned char, unsigned char>'
  267 |                 end_color = { 92, 204, 150 })
      |                 ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_pair.h:90:11: note: template is declared here
   90 |     class tuple;
      |           ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:267:17: note: passing argument to parameter 'end_color' here
  267 |                 end_color = { 92, 204, 150 })
      |                 ^
4 errors generated.
make[2]: *** [CMakeFiles/main.dir/build.make:76: CMakeFiles/main.dir/main.cc.o] Error 1
make[2]: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/main.dir/all] Error 2
make[1]: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make: *** [Makefile:91: all] Error 2
make: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'

[Aaalibaba42]

I don't have a debian machine available (I'll setup github actions to buid soon). Do you think it comes from implicit includes ? winsize indeed is in sys/ioctl.h, which is not explicitely included.

[Aaalibaba42]

Can you try on the linked PR ( #8 ) @MartinBourbier ?

[MartinBourbier]

Can you try on the linked PR ( #8 ) @MartinBourbier ?

I'll try this afternoon

[MartinBourbier]

The problem still occurs with the exact same output.
Note that a similar problem happens with gcc 14:

g++-14.1.0 (GCC) 14.2.0

42sh$ CXX="/usr/local/gcc-14.1.0/bin/g++-14.1.0" cmake -B build
-- The CXX compiler identification is GNU 14.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/gcc-14.1.0/bin/g++-14.1.0 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/g704120/cxx_tuncfest/samples/simple/build

42sh$ make -C build/
make: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[1]: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[2]: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[2]: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[2]: Entering directory '/home/g704120/cxx_tuncfest/samples/simple/build'
[ 50%] Building CXX object CMakeFiles/main.dir/main.cc.o
In file included from /home/g704120/cxx_tuncfest/samples/simple/main.cc:1:
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh: In function ‘int Runner::Output::get_terminal_width()’:
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:257:28: error: aggregate ‘Runner::Output::get_terminal_width()::winsize w’ has incomplete type and cannot be defined
  257 |             struct winsize w;
      |                            ^
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:258:34: error: ‘TIOCGWINSZ’ was not declared in this scope
  258 |             ioctl(STDOUT_FILENO, TIOCGWINSZ, &w);
      |                                  ^~~~~~~~~~
/home/g704120/cxx_tuncfest/samples/simple/build/_deps/tuncfest-src/tuncfest/tuncfest.hh:258:13: error: ‘ioctl’ was not declared in this scope
  258 |             ioctl(STDOUT_FILENO, TIOCGWINSZ, &w);
      |             ^~~~~
make[2]: *** [CMakeFiles/main.dir/build.make:76: CMakeFiles/main.dir/main.cc.o] Error 1
make[2]: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/main.dir/all] Error 2
make[1]: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'
make: *** [Makefile:91: all] Error 2
make: Leaving directory '/home/g704120/cxx_tuncfest/samples/simple/build'

[Aaalibaba42]

Ok, apparently sys/ioctl.h is moved to termios.h on some libcs because of POSIX standardization efforts or something. I'm going to look it up more for a fix

[Aaalibaba42]

Apparently what is Linux specific should still be in sys/ioctl.h, but what's shared should live in termios.h, so boths need to be included. I've made this change on the MR. I'm sorry to ask you again if this fixes the issue @MartinBourbier ?

[MartinBourbier]

I get the exact same error with clang19

[Aaalibaba42]

Okay, I'll setup something to debug myself. I'll come back to you when I understand from where this stems.