Startup exceptions show a name of the mod causing them #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
reviewed
Apr 26, 2022
modloader/__init__.py
Outdated
| update_modtools(args.url) | ||
|
|
||
|
|
||
| def mod_error(phase, mod_name, e): |
Contributor
There was a problem hiding this comment.
I'd change the signature so it's called as mod_error_check(lamba: importlib.import_module(mod), state="importing")
Contributor
There was a problem hiding this comment.
Or with but I'm not sure if that's py2 compatible
Contributor
Author
There was a problem hiding this comment.
How would I use it in this case tho where the following code needs the return value?
Could use a nested function but that would make it less clean than it is now.
try:
mod_object = importlib.import_module(mod)
except Exception as e:
mod_error("importing", mod, e)
muddyfish
reviewed
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During importing, loading and completing of mods, all exceptions get caught and reraised with a name of the mod which caused them included in the error message. Original traceback is preserved.
Visibly showing a name of the mod causing the startup error should be very helpful for normal players who don't want to dig through the traceback and just want to know which mod author to scream at.