Fix implicit resolution conflict when MongoPolyDataCompanion is used with custom implicits #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with custom implicits
mikegpl
reviewed
Feb 3, 2023
...-mongo/jvm/src/main/scala-2.13/com/avsystem/commons/mongo/typed/MongoPolyDataCompanion.scala
Show resolved
Hide resolved
|
Note: I decided to ignore binary compatibility as there is literally 0 chance this quite obscure feature is used in any library code. |
mikegpl
approved these changes
Feb 6, 2023
...-mongo/jvm/src/main/scala-2.13/com/avsystem/commons/mongo/typed/MongoPolyDataCompanion.scala
Show resolved
Hide resolved
ddworak
approved these changes
Feb 6, 2023
...o/jvm/src/test/scala-2.13/com/avsystem/commons/mongo/typed/PolyDataWithCustomImplicits.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoPolyAdtInstances.codecFromFormatwas a bit too broad and conflicted with implicits injected viaMacroInstances.This is a rather obscure scenario, please see the added test which shows the minimized problem.