Mapping scala BigDecimal to BSON NumberDecimal instead of binary

[pulewicz]

What is the best to map scala.math.BigDecimal to NumberDecimal instead of binary?

I created a repo with this example and currently it looks like that:

case class TypeWithBigDecimal(x: BigDecimal, y: BigDecimal)

TypeWithBigDecimal(x = 103234.42343, y = 12344.423)

{"x": {"$binary": {"base64": "AmdTOqcAAAAF", "subType": "00"}}, "y": {"$binary": {"base64": "ALxcZwAAAAM=", "subType": "00"}}}

https://github.com/pulewicz/mongo-commons-playground/blob/master/src/main/scala/PlaygroundApp.scala#L89

From what I see, this is currently hardcoded in all of of the Bson outputs, so I guess the only way would be to create your own output implementation, isn't it?

https://github.com/AVSystem/scala-commons/blob/master/commons-mongo/jvm/src/main/scala/com/avsystem/commons/mongo/BsonValueOutput.scala#L39
https://github.com/AVSystem/scala-commons/blob/master/commons-mongo/jvm/src/main/scala/com/avsystem/commons/mongo/BsonWriterOutput.scala#L26
https://github.com/AVSystem/scala-commons/blob/master/commons-mongo/jvm/src/main/scala/com/avsystem/commons/mongo/BsonWriterOutput.scala#L63

Are you planning to make it configurable?

Regards,
Paweł Ulewicz.

[ghik]

Hi,

Yes, Output implementations should use Decimal128 representation where possible. Stay tuned for a PR

Thanks,
Roman

[pulewicz]

Hi,

Thanks for a quick response. For our specific purpose, using org.bson.types.Decimal128 directly in a case class along with HasGenCodecWithDep solved the problem, but a simpler and more elegant solution would be even better.

Thanks again for your help.

Regards,
Paweł Ulewicz

[ghik]

Fixed in 2.6.0