Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subpath support #9865

Merged
merged 3 commits into from
May 2, 2023
Merged

add subpath support #9865

merged 3 commits into from
May 2, 2023

Conversation

catalpaaa
Copy link
Contributor

Describe what this pull request is trying to achieve.

add support to apply a custom subpath for launching gradio in, use when reverse proxied.

also maybe bump gradio to 3.28 after its out, i think it fixed some symlinks subpath thingy, it fixes #7028

Additional notes and description of your changes

issues for more context for what this fix

Environment this was tested in

List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.

  • OS: ubuntu 22
  • Browser: chrome, safari
  • Graphics card: NVIDIA RTX 2080 8GB

Screenshots or videos of your changes

before:
image
after:
image

@AUTOMATIC1111
Copy link
Owner

don't put multiple unrelated things into same PR
webui.sh change should not be included also

@catalpaaa
Copy link
Contributor Author

catalpaaa commented Apr 29, 2023

don't put multiple unrelated things into same PR

webui.sh change should not be included also

Sry, i don't know why but the GitHub desktop just keep including that

The bump for gradio is for a bug fix that fix symlink path on windows, and a bug fix for not releasing custom port during a restart

@AUTOMATIC1111 AUTOMATIC1111 changed the base branch from master to dev May 2, 2023 07:55
@AUTOMATIC1111 AUTOMATIC1111 merged commit 4b6808f into AUTOMATIC1111:dev May 2, 2023
AUTOMATIC1111 added a commit that referenced this pull request May 2, 2023
@catalpaaa catalpaaa deleted the subpath-support branch June 3, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gradio issue, "Value Error: File cannot be fetched: <... extensions/...the file...>"
2 participants