Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls modules.sd_vae.refresh_vae_list(), fixes VAE list not updating #7583

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

EllangoK
Copy link
Collaborator

@EllangoK EllangoK commented Feb 6, 2023

Closes #7553.

We should be calling the method to actually update the list. Just returning it does not update the list.
It is used here

"sd_vae": OptionInfo("Automatic", "SD VAE", gr.Dropdown, lambda: {"choices": shared_items.sd_vae_items()}, refresh=shared_items.refresh_vae_list),

If we look at the other ones such as sd_model_checkpoint, it uses refresh_checkpoints, whose definition is also shown below

"sd_model_checkpoint": OptionInfo(None, "Stable Diffusion checkpoint", gr.Dropdown, lambda: {"choices": list_checkpoint_tiles()}, refresh=refresh_checkpoints),
def refresh_checkpoints():
import modules.sd_models
return modules.sd_models.list_models()

@AUTOMATIC1111 AUTOMATIC1111 merged commit 563724f into AUTOMATIC1111:master Feb 19, 2023
AUTOMATIC1111 added a commit that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: vae does not appear when clicking refresh button in models/VAE
2 participants