Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upscale logic #16239

Merged
merged 1 commit into from
Jul 20, 2024
Merged

fix upscale logic #16239

merged 1 commit into from
Jul 20, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jul 19, 2024

Description

note the "infinite loop" description is incorrect

when using a Non-1x upscaller but if the Scale is set to 1x, there will be no check for the current image size, and will casue the upscale to loop until the max range 3 is reached

desired behavior

1x model 4x modle
1x scale run 1 time run 1 time
4x scale run 1 time run 1 time
8x scale run 1 time run 2 time

current behavior

1x model 4x modle
1x scale run 1 time run till max loop
4x scale run 1 time run 1 time
8x scale run 1 time run 2 time

this PR fix the 4x model + 1x scale -> run till max loop issue

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit e09104a into dev Jul 20, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-upscale-logic branch July 20, 2024 08:41
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants