Webui.sh Update: Fixed Git check for users running Stable Diffusion within their personal repositories. #14632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhancement introduces a crucial check for the existence of the 'stable-diffusion-webui' folder within the project directory. The motivation behind this addition is to mitigate potential conflicts when the project is situated within another Git repository, a situation often encountered when users operate live servers with their own Git configurations. Previously, the absence of this check could lead to unintended interactions with the enclosing Git repository, resulting in unforeseen issues. Now, by verifying the presence of the 'stable-diffusion-webui' folder, the script ensures a more resilient and isolated deployment. If the folder exists, it is leveraged as the install directory, guaranteeing a seamless integration while minimizing the risk of interference with surrounding Git repositories. This improvement aims to elevate compatibility and prevent unintended consequences, especially in scenarios where the project coexists within other Git-controlled environments.
|
The way I see it, the check will only succeed if you are in some directory that has .git in it, and you run the webui.sh as |
|
But as per the instructions clearly written on the main repo readme file
you firstly getting the webui.sh so most of the people do follow that so
why don't we make it generic..?? For alll use cases
…On Fri, 12 Jan 2024, 4:47 pm AUTOMATIC1111, ***@***.***> wrote:
The way I see it, the check will only succeed if you are in some directory
that has .git in it, and you run the webui.sh as
stable-diffusion-webui/webui.sh from that directory. I can't imagine
people doing that. It's way to specific. It may help with some use case of
yours but I don't want to add more lines of code that help almost no one.
—
Reply to this email directly, view it on GitHub
<#14632 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXJW3NHDYT3PAMC54R7FE3YOEPDNAVCNFSM6AAAAABBX6IJI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYHE2TCOBTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
And most of the people do just download webui.sh file and they proceed
further that will clone into sub folder named sd-webui.... And what if the
person who have just download the bash file and running it inside hiw own
git repo
…On Fri, 12 Jan 2024, 5:28 pm Rana Rehan, ***@***.***> wrote:
But as per the instructions clearly written on the main repo readme file
you firstly getting the webui.sh so most of the people do follow that so
why don't we make it generic..?? For alll use cases
On Fri, 12 Jan 2024, 4:47 pm AUTOMATIC1111, ***@***.***>
wrote:
> The way I see it, the check will only succeed if you are in some
> directory that has .git in it, and you run the webui.sh as
> stable-diffusion-webui/webui.sh from that directory. I can't imagine
> people doing that. It's way to specific. It may help with some use case of
> yours but I don't want to add more lines of code that help almost no one.
>
> —
> Reply to this email directly, view it on GitHub
> <#14632 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEXJW3NHDYT3PAMC54R7FE3YOEPDNAVCNFSM6AAAAABBX6IJI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYHE2TCOBTGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webui.sh Update: Fixed Git check for users running Stable Diffusion within their personal repositories.
This enhancement introduces a crucial check for the existence of the 'stable-diffusion-webui' folder within the project directory. The motivation behind this addition is to mitigate potential conflicts when the project is situated within another Git repository, a situation often encountered when users operate live servers with their own Git configurations.
Previously, the absence of this check could lead to unintended interactions with the enclosing Git repository, resulting in unforeseen issues. Now, by verifying the presence of the 'stable-diffusion-webui' folder, the script ensures a more resilient and isolated deployment. If the folder exists, it is leveraged as the install directory, guaranteeing a seamless integration while minimizing the risk of interference with surrounding Git repositories.
This improvement aims to elevate compatibility and prevent unintended consequences, especially in scenarios where the project coexists within other Git-controlled environments.
Description
Screenshots/videos:
Checklist: