-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard shortcuts for generate/skip/interrupt #14269
Add keyboard shortcuts for generate/skip/interrupt #14269
Conversation
(Removed Alt+Enter) Ctrl+Enter to start/restart generation (New) Alt/Option+Enter to skip generation (New) Ctrl+Alt/Option+Enter to interrupt generation
I think escape would make more sense. |
Perhaps, yes. But it's necessary to check that Esc to close popup 01c8f18 does not interfere with Esc during generation. For example, if I want to edit the styles while the generation is in progress :) I'll supplement the commit a little later. |
script.js
Outdated
} else { | ||
if (!globalPopup) return; | ||
globalPopup.style.display = "none"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This else
isn't necessary, the existing handler is still gonna fire.
Esc is also used to close the full screen image viewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip! Made the edits.
Description
A small addition to #13644
Ctrl+Enter to start/restart a generation
add: Alt+Enter to skip
add: Esc to interrupt (if there is a popup or lightbox, closes it first)
Screenshots/videos:
skip-interrupt-keyb-shortcuts.mp4
Checklist: