Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --ckpt-dir command-line argument when merging models #1261

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

moorehousew
Copy link
Contributor

--ckpt-dir is now respected by the checkpoint merging code, and subdirectories are supported. Fixes #1224.

@moorehousew
Copy link
Contributor Author

Also fixed .gitignore again- checkpoint files in subdirectories of /models will now be ignored.

@AUTOMATIC1111
Copy link
Owner

you're meant to be able to input absolute filename (including extension) in there - this is what os.path.exists is checking for. If the absolute filename does not exist, then you should check cmd_opts.ckpt_dir instead of 'models/'

@AUTOMATIC1111
Copy link
Owner

and cmd_opts.ckpt_dir should be just assumed to exist

@moorehousew
Copy link
Contributor Author

Could you clarify? The current UI behavior seems to prevent someone from ever entering an absolute filename for a checkpoint. Can assume ckpt_dir exists though.

@AUTOMATIC1111
Copy link
Owner

oh, now i get it; it has been updated to use the dropdown and I forgot about that

@moorehousew
Copy link
Contributor Author

moorehousew commented Sep 28, 2022

Let me test if it still works as expected with your changes- better to leave that functionality in for later, I'd imagine.

EDIT: It did not work, the model output name got garbled. This should do for now.

@moorehousew
Copy link
Contributor Author

Alright, it works as expected now with the assumption that ckpt_dir always exists.

@moorehousew
Copy link
Contributor Author

Looks like you added most of the changes to master already- don't forget the .gitignore and UI fixes.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 041d2ae into AUTOMATIC1111:master Sep 28, 2022
nne998 pushed a commit to fjteam/stable-diffusion-webui that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint Merger - FileNotFoundError: [Errno 2] No such file or directory:
2 participants