Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Update keyboard shortcut instructions for MacOS users #10581

Merged
merged 1 commit into from
May 21, 2023

Conversation

shinshin86
Copy link
Contributor

Hello,

Describe what this pull request is trying to achieve.

During my usage, I noticed that the instructions for adjusting the attention to selected text are primarily focused on non-Mac users. As it currently stands, the instructions only mention the Ctrl+Up and Ctrl+Down shortcuts. This might cause a bit of confusion for Mac users, who are more accustomed to using the Command key for such actions.

I also would like to gently point out that there may be Mac users accessing this tool via platforms like Google Colab. My proposed change, though minor, might contribute to a more comfortable experience for those users by potentially reducing confusion and aiding in more intuitive interaction.

In light of this, I've taken the liberty of proposing a minor change to the instruction text to include "or Command+Up or Command+Down if you're on a MacOS".
This slight modification could make the tool more intuitive for Mac users.

While I realize this is a minor point, I believe this change could contribute to a more inclusive user experience, particularly for Mac users.

Thank you for taking the time to review this proposal, and please feel free to let me know if there are any changes or adjustments you'd like me to make.

Additional notes and description of your changes

The only change is in the README text.

Environment this was tested in

Confirmed on GitHub.
(OS - MacOS, Browser - Chrome)

@shinshin86 shinshin86 requested a review from AUTOMATIC1111 as a code owner May 20, 2023 21:55
@AUTOMATIC1111 AUTOMATIC1111 merged commit 6fe85e8 into AUTOMATIC1111:dev May 21, 2023
@shinshin86 shinshin86 deleted the readme-mac-shortcut branch May 21, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants