Error improvement for install torch #10499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
In other words, PyTorch does not have support for 32-bit systems. It seems a bit unintuitive. |
dongweiming
force-pushed
the
error-improvement
branch
from
883daf5 to
6ea34ac
Compare
|
@Sakura-Luna Before, I thought that there were many architectures, and we only limited the supported ones, and the others reported errors. But what you said is also right, so I modified the check method, and the 32-bit system will report an error and exit. |
dongweiming
force-pushed
the
error-improvement
branch
from
6ea34ac to
aa6e98e
Compare
AUTOMATIC1111
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve.
I have seen a lot of issues about the failure to install packages such as
torch, most of which are due to systems using an architecture that torch currently does not support. for example, #10444, If it shows(from versions: none)except that an unsupported python version is used, it is for this reason.So I think when the user runs
webui.sh, directly throwing an error and pointing out the reason will make the user understand the problem more clearly, which can reduce the number of related issues.List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.
Screenshots or videos of your changes