-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting ConCert to Metacoq v1.0+8.14 #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t commands; update docker files
Closed
I've created a branch coq-8.11 with the current state of |
@4ever2 should I do anything else before merging the PR? |
No, it should be ready to merge. |
4ever2
added
type: refactor
Refactorings, code removal, etc
part: extraction
Issues and PRs related to extraction framework
labels
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part: extraction
Issues and PRs related to extraction framework
type: refactor
Refactorings, code removal, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difficulty was the
tCase
representation and the corresponding meta-theory.All code and examples work. However, there are
Admitted
lemmas:TypeAnnotations
: a proof obligation related totCase
typing is admitted.ExtractionCorrectness.v
requires proofs that our recursive environment erasure produces a well-formedwf_glob
environment.MetaCoq has a similar erasure function, but we can ignore dependencies which were remapped.
Moreover, we not only erase terms but we apply our erasure for types and produce extended environment, containing typing information.
So, we cannot just use MetaCoq environment erasure and its properties.
I guess we need a bunch of lemmas that our way working with dependencies is the same as in MetaCoq.
The best way is probably leave it for now and let MetaCoq team help us to integrate it.
Other issues:
string
from the stdlib, but MetaCoq usesbytestring
that is copied from the BedRock project https://github.com/MetaCoq/metacoq/blob/coq-8.16/template-coq/theories/utils/bytestring.v.We should as MetaCoq developers, whether it's possible to put
bytestring
toopam
, so we can use it for all our stuff as a dependency.For now, we convert between this representation back and forth, which is inefficient and annoying due to name/scope/... issues.