fix: dont override default report options in charts

Sales analytics and purchase analytics reports are clearing the default options which includes number shortening, axis options etc. This makes report unreadable when dealing with large numbers.
ASSAohs · Jul 15, 2022 · ceeea61 · ceeea61
1 parent d7446fd
commit ceeea61
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/erpnext/buying/report/purchase_analytics/purchase_analytics.js b/erpnext/buying/report/purchase_analytics/purchase_analytics.js
@@ -130,11 +130,8 @@ frappe.query_reports["Purchase Analytics"] = {
 						labels: raw_data.labels,
 						datasets: new_datasets,
 					};
-					chart_options = {
-						data: new_data,
-						type: "line",
-					};
-					frappe.query_report.render_chart(chart_options);
+					const new_options = Object.assign({}, frappe.query_report.chart_options, {data: new_data});
+					frappe.query_report.render_chart(new_options);
 
 					frappe.query_report.raw_chart_data = new_data;
 				},

diff --git a/erpnext/selling/report/sales_analytics/sales_analytics.js b/erpnext/selling/report/sales_analytics/sales_analytics.js
@@ -109,11 +109,8 @@ frappe.query_reports["Sales Analytics"] = {
 						labels: raw_data.labels,
 						datasets: new_datasets,
 					};
-
-					frappe.query_report.render_chart({
-						data: new_data,
-						type: "line",
-					});
+					const new_options = Object.assign({}, frappe.query_report.chart_options, {data: new_data});
+					frappe.query_report.render_chart(new_options);
 
 					frappe.query_report.raw_chart_data = new_data;
 				},