Skip to content

Commit

Permalink
fix: Explicitly update modified (frappe#32519)
Browse files Browse the repository at this point in the history
* fix: Explicitly update modified

required after frappe/frappe#18301

* chore: fix broken translations
  • Loading branch information
ankush authored Oct 6, 2022
1 parent 07c4a74 commit 8376fbc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
11 changes: 7 additions & 4 deletions erpnext/stock/doctype/bin/bin.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ def update_reserved_qty_for_production(self):

self.set_projected_qty()

self.db_set("reserved_qty_for_production", flt(self.reserved_qty_for_production))
self.db_set("projected_qty", self.projected_qty)
self.db_set(
"reserved_qty_for_production", flt(self.reserved_qty_for_production), update_modified=True
)
self.db_set("projected_qty", self.projected_qty, update_modified=True)

def update_reserved_qty_for_sub_contracting(self, subcontract_doctype="Subcontracting Order"):
# reserved qty
Expand Down Expand Up @@ -118,9 +120,9 @@ def update_reserved_qty_for_sub_contracting(self, subcontract_doctype="Subcontra
else:
reserved_qty_for_sub_contract = 0

self.db_set("reserved_qty_for_sub_contract", reserved_qty_for_sub_contract)
self.db_set("reserved_qty_for_sub_contract", reserved_qty_for_sub_contract, update_modified=True)
self.set_projected_qty()
self.db_set("projected_qty", self.projected_qty)
self.db_set("projected_qty", self.projected_qty, update_modified=True)


def on_doctype_update():
Expand Down Expand Up @@ -193,4 +195,5 @@ def update_qty(bin_name, args):
"planned_qty": planned_qty,
"projected_qty": projected_qty,
},
update_modified=True,
)
2 changes: 1 addition & 1 deletion erpnext/stock/stock_ledger.py
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ def update_bin(self):
updated_values = {"actual_qty": data.qty_after_transaction, "stock_value": data.stock_value}
if data.valuation_rate is not None:
updated_values["valuation_rate"] = data.valuation_rate
frappe.db.set_value("Bin", bin_name, updated_values)
frappe.db.set_value("Bin", bin_name, updated_values, update_modified=True)


def get_previous_sle_of_current_voucher(args, exclude_current_voucher=False):
Expand Down
2 changes: 1 addition & 1 deletion erpnext/translations/fr.csv
Original file line number Diff line number Diff line change
Expand Up @@ -4946,7 +4946,7 @@ Min Amt,Montant Min,
Max Amt,Montant Max,
"If rate is zero them item will be treated as ""Free Item""",Si le prix est à 0 alors l'article sera traité comme article gratuit
Is Recursive,Est récursif
"Discounts to be applied in sequential ranges like buy 1 get 1, buy 2 get 2, buy 3 get 3 and so on",La remise sera appliquée séquentiellement telque : acheter 1 => recupérer 1, acheter 2 => recupérer 2, acheter 3 => recupérer 3, etc...
"Discounts to be applied in sequential ranges like buy 1 get 1, buy 2 get 2, buy 3 get 3 and so on","La remise sera appliquée séquentiellement telque : acheter 1 => recupérer 1, acheter 2 => recupérer 2, acheter 3 => recupérer 3, etc..."
Period Settings,Paramètres de période,
Margin,Marge,
Margin Type,Type de Marge,
Expand Down

0 comments on commit 8376fbc

Please sign in to comment.